-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Make CI workflows fork-friendly #19807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wallentx <[email protected]>
Signed-off-by: wallentx <[email protected]>
Signed-off-by: wallentx <[email protected]>
8873de8
to
afd1f18
Compare
Pull Request Test Coverage Report for Build 16351588853Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
hoffmang9
approved these changes
Aug 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Starttoaster
approved these changes
Aug 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Changed
Required label for PR that categorizes merge commit message as "Changed" for changelog
community-pr
Exclude_Notes
Use this label if the changes in the PR should be excluded from the release notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose:
This PR improves the CI experience for external contributors by ensuring that jobs can run successfully on forks. It resolves an issue where many CI jobs would get stuck in a pending state indefinitely because they were configured to use self-hosted runners that are only available in the
chia-network/chia-blockchain
repository. This change allows contributors to get timely and accurate feedback from the CI system.This PR does not introduce a breaking change.
Current Behavior:
Currently, several CI jobs are configured to use specific self-hosted runners (e.g.,
[Linux, ARM64]
,macos-13-arm64
,benchmark
). When a contributor creates a pull request on their fork, these jobs are triggered but can never be assigned to a runner, as the required self-hosted runners do not exist in their forked repository. This causes the jobs to remain in a "pending" state forever, providing no feedback and cluttering the pull request's checks.New Behavior:
The workflows have been updated with conditional logic based on the repository owner (
github.repository_owner
).Chia-Network
Organization, it will continue to use the specialized self-hosted runners as before.ubuntu-22.04-arm
,macos-latest
).This ensures that all CI jobs can run to completion on forks, providing contributors with the feedback they need.
Testing Notes:
Tested on my fork wallentx#19